powerpc/hash: Skip non initialized page size in init_hpte_page_sizes

Michael Ellerman patch-notifications at ellerman.id.au
Mon Jan 22 14:34:11 AEDT 2018


On Tue, 2017-11-28 at 08:34:40 UTC, "Aneesh Kumar K.V" wrote:
> One of the easiest way to test config with 4K HPTE is to disable 64K hardware
> page size like below.
> 
> int __init htab_dt_scan_page_sizes(unsigned long node,
> 
>  		size -= 3; prop += 3;
>  		base_idx = get_idx_from_shift(base_shift);
> -		if (base_idx < 0) {
> +		if (base_idx < 0 || base_idx == MMU_PAGE_64K) {
>  			/* skip the pte encoding also */
>  			prop += lpnum * 2; size -= lpnum * 2;
> 
> But then this results in error in other part of the code such as MPSS parsing
> where we look at 4K base page size and 64K actual page size support.
> 
> This patch fix MPSS parsing by ignoring the actual page sizes marked
> unsupported. In reality this can happen only with a corrupt device tree. But it
> is good to tighten the error check.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/10527e808123f4b12db604993638b3

cheers


More information about the Linuxppc-dev mailing list