[PATCH] PCI/AER: Move pci_uevent_ers() out of pci.h

Michael Ellerman mpe at ellerman.id.au
Fri Feb 23 15:09:32 AEDT 2018


Bjorn Helgaas <helgaas at kernel.org> writes:
> On Thu, Feb 08, 2018 at 11:20:35PM +1100, Michael Ellerman wrote:
>> There's no reason pci_uevent_ers() needs to be inline in pci.h, so
>> move it out to a C file.
>> 
>> Given it's used by AER the obvious location would be somewhere in
>> drivers/pci/pcie/aer, but because it's also used by powerpc EEH code
>> unfortunately that doesn't work in the case where EEH is enabled but
>> PCIEPORTBUS is not.
>> 
>> So for now put it in pci-driver.c, next to pci_uevent(), with an
>> appropriate #ifdef so it's not built if AER and EEH are both disabled.
>> 
>> While we're moving it also fix up the kernel doc comment for @pdev to
>> be accurate.
>> 
>> Reported-by: Linus Torvalds <torvalds at linux-foundation.org>
>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>
> Applied to pci/aer for v4.17, thanks!

Thanks.

cheers


More information about the Linuxppc-dev mailing list