[PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

Viresh Kumar viresh.kumar at linaro.org
Wed Feb 21 21:02:09 AEDT 2018


On 21-02-18, 10:27, Rafael J. Wysocki wrote:
> To be precise, ->init() should fail as that's where the table is
> created.  The registration fails as a result then.
> 
> But what if the bug is that ->init() doesn't fail when it should?
> 
> I guess the core could double check the frequency table after ->init()
> if ->target_index is not NULL.
> 
> The overall point here is that if you get a negative index in
> ->fast_switch(), that's way too late anyway and we should be able to
> catch that error much earlier.

I don't want to end up doing double checking as some of it is already
done at init, but let me check on what can be done.

-- 
viresh


More information about the Linuxppc-dev mailing list