[RFC PATCH 1/2] powerpc/64: drop redundant defination of spin_until_cond
Sudeep Holla
sudeep.holla at arm.com
Tue Feb 20 02:45:06 AEDT 2018
linux/processor.h has exactly same defination for spin_until_cond.
Drop the redundant defination in asm/processor.h
Cc: Nicholas Piggin <npiggin at gmail.com>
Cc: Michael Ellerman <mpe at ellerman.id.au>
Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
---
arch/powerpc/include/asm/processor.h | 11 -----------
1 file changed, 11 deletions(-)
Hi,
When I was planning to use spin_until_cond, I came across the same defination
at 2 different headers, one of which includes the other and takes care of
enabling the defination in case of undefinded condition.
I found it redundant, but I may be wrong.
Regards,
Sudeep
diff --git a/arch/powerpc/include/asm/processor.h b/arch/powerpc/include/asm/processor.h
index 01299cdc9806..4816be3be02c 100644
--- a/arch/powerpc/include/asm/processor.h
+++ b/arch/powerpc/include/asm/processor.h
@@ -438,17 +438,6 @@ static inline unsigned long __pack_fe01(unsigned int fpmode)
#define spin_end() HMT_medium()
-#define spin_until_cond(cond) \
-do { \
- if (unlikely(!(cond))) { \
- spin_begin(); \
- do { \
- spin_cpu_relax(); \
- } while (!(cond)); \
- spin_end(); \
- } \
-} while (0)
-
#else
#define cpu_relax() barrier()
#endif
--
2.7.4
More information about the Linuxppc-dev
mailing list