[PATCH] powerpc/xmon: Dont register sysrq key when kernel param xmon=off

Balbir Singh bsingharora at gmail.com
Mon Feb 12 22:12:13 AEDT 2018

On Mon, Feb 12, 2018 at 7:59 PM, Vaibhav Jain
<vaibhav at linux.vnet.ibm.com> wrote:
> Presently sysrq key for xmon('x') is registered during kernel init
> irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
> even if 'xmon=off' is passed on the kernel command line.
> This minor patch updates setup_xmon_sysrq() to register
> 'sysrq_xmon_op' only when variable 'xmon_on' is set.
> Signed-off-by: Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
> ---

Any specific issue you've run into without this patch? I presume
running xmon=off indicates we don't want xmon to take over in case of
panic/die/oops, why are we tying this to sysrq?

Balbir Singh.

More information about the Linuxppc-dev mailing list