[kernel] powerpc/pci: Fix broken INTx configuration via OF

Michael Ellerman mpe at ellerman.id.au
Fri Feb 9 16:34:07 AEDT 2018


Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 09/02/18 15:00, Michael Ellerman wrote:
>> On Thu, 2018-02-08 at 05:33:54 UTC, Alexey Kardashevskiy wrote:
>>> Commit 59f47eff03a0 ("powerpc/pci: Use of_irq_parse_and_map_pci() helper")
>>> correctly states that of_irq_parse_and_map_pci() does the same thing as
>>> of_irq_parse_pci() does as it simply calls
>>> of_irq_parse_pci() and irq_create_of_mapping().
>>>
>>> However of_irq_parse_and_map_pci() not only returns 0 for success and
>>> negative value for an error but also a positive virq value from
>>> irq_create_of_mapping() which the mentioned commit ignores and
>>> INTx config fails.
>>>
>>> This fixes the of_irq_parse_and_map_pci() return value handling.
>>>
>>> Fixes: 59f47eff03a0 "powerpc/pci: Use of_irq_parse_and_map_pci() helper"
>>> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>> 
>> Applied to powerpc fixes, thanks.
>> 
>> https://git.kernel.org/powerpc/c/560c0f978155282e36f33d21b2aeae
>
>
> there is a v2, this one is not 100% correct

Yeah I just saw, I'll back this out.

cheers


More information about the Linuxppc-dev mailing list