Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

[wen.yang99 at zte.com.cn]

Hi David，
Thank you, we'll fix it soon.

Best wishes,
  Wen
------------------Original Mail------------------
Sender: DavidMiller <davem at davemloft.net>
To: peng hao10096742;
CC: qiang.zhao at nxp.com <qiang.zhao at nxp.com>leoyang.li at nxp.com <leoyang.li at nxp.com>linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>wen yang10156314;julia.lawall at lip6.fr <julia.lawall at lip6.fr>netdev at vger.kernel.org <netdev at vger.kernel.org>linuxppc-dev at lists.ozlabs.org <linuxppc-dev at lists.ozlabs.org>
Date: 2018/12/29 13:11
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From: Peng Hao <peng.hao2 at zte.com.cn>
Date: Wed, 26 Dec 2018 16:26:29 +0800

> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
>      .ndo_tx_timeout    = uhdlc_tx_timeout,
>  };
>
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
...
> +    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +    return 0;

This assignment to 'res' doesn't do what you think it does.  The caller never
sees the value you compute.