[PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

Scott Wood oss at buserror.net
Sat Dec 22 13:29:56 AEDT 2018


On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote:
> devm_kstrdup() may return NULL if internal allocation failed, but
> as  machine  is from the device tree, and thus RO, devm_kstrdup_const()
> can be used here, which will only copy the reference.

Is it really going to only copy the reference?  That would require that
is_kernel_rodata(machine) be true, which it shouldn't be since it's not part
of the kernel image.

-Scott




More information about the Linuxppc-dev mailing list