[RFC 3/5] powerpc/mpic: Add support for non-contiguous irq ranges

Scott Wood oss at buserror.net
Wed Aug 8 15:50:38 AEST 2018


On Wed, 2018-08-08 at 03:37 +0000, Bharat Bhushan wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss at buserror.net]
> > Sent: Wednesday, August 8, 2018 2:34 AM
> > To: Rob Herring <robh at kernel.org>; Bharat Bhushan
> > <bharat.bhushan at nxp.com>
> > Cc: benh at kernel.crashing.org; paulus at samba.org; mpe at ellerman.id.au;
> > galak at kernel.crashing.org; mark.rutland at arm.com;
> > kstewart at linuxfoundation.org; gregkh at linuxfoundation.org;
> > devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; linux-
> > kernel at vger.kernel.org; keescook at chromium.org;
> > tyreld at linux.vnet.ibm.com; joe at perches.com
> > Subject: Re: [RFC 3/5] powerpc/mpic: Add support for non-contiguous irq
> > ranges
> > 
> > On Tue, 2018-08-07 at 12:09 -0600, Rob Herring wrote:
> > > On Fri, Jul 27, 2018 at 03:17:59PM +0530, Bharat Bhushan wrote:
> > > > Freescale MPIC h/w may not support all interrupt sources reported by
> > > > hardware, "last-interrupt-source" or platform. On these platforms a
> > > > misconfigured device tree that assigns one of the reserved
> > > > interrupts leaves a non-functioning system without warning.
> > > 
> > > There are lots of ways to misconfigure DTs. I don't think this is
> > > special and needs a property.
> > 
> > Yeah, the system will be just as non-functioning if you specify a valid-
> > but-
> > wrong-for-the-device interrupt number.
> 
> Some is one additional benefits of this changes, MPIC have reserved regions
> for un-supported interrupts and read/writes to these reserved regions seams
> have no effect.
> MPIC driver reads/writes to the reserved regions during init/uninit and
> save/restore state.
> 
> Let me know if it make sense to have these changes for mentioned reasons.

The driver has been doing this forever with no ill effect.  What is the
motivation for this change?

-Scott



More information about the Linuxppc-dev mailing list