[PATCH] powpc:feature: of_node_put is not needed after iterator.
Tyrel Datwyler
tyreld at linux.vnet.ibm.com
Sun Aug 5 06:37:39 AEST 2018
On 08/04/2018 07:25 AM, zhong jiang wrote:
> for_each_node_by_name iterators only exit normally when the loop
> cursor is NULL, So there is no point to call of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang at huawei.com>
Reviewed-by: Tyrel Datwyler <tyreld at linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/powermac/feature.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 3f82cb2..4eb8cb3 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
> /* On all machines, switch modem & serial ports off */
> for_each_node_by_name(np, "ch-a")
> initial_serial_shutdown(np);
> - of_node_put(np);
> for_each_node_by_name(np, "ch-b")
> initial_serial_shutdown(np);
> - of_node_put(np);
> }
>
> void __init
>
More information about the Linuxppc-dev
mailing list