[PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"

[David Hildenbrand]

On 16.09.2017 22:12, Jan H. Schönherr wrote:
> This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563.
> 
> The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
> there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
> gsi values make sense.
> 
> As the commit was meant as an early indicator to user space that
> something is wrong, reverting just restores the previous behavior
> where overly large values are ignored when encountered (without
> any direct feedback).
> 
> Reported-by: Abdul Haleem <abdhalee at linux.vnet.ibm.com>
> Signed-off-by: Jan H. Schönherr <jschoenh at amazon.de>
> ---
>  virt/kvm/eventfd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index c608ab4..f2ac53a 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -565,8 +565,6 @@ kvm_irqfd(struct kvm *kvm, struct kvm_irqfd *args)
>  {
>  	if (args->flags & ~(KVM_IRQFD_FLAG_DEASSIGN | KVM_IRQFD_FLAG_RESAMPLE))
>  		return -EINVAL;
> -	if (args->gsi >= KVM_MAX_IRQ_ROUTES)
> -		return -EINVAL;
>  
>  	if (args->flags & KVM_IRQFD_FLAG_DEASSIGN)
>  		return kvm_irqfd_deassign(kvm, args);
> 

Makes sense and shouldn't do any harm as you also mentioned.

Reviewed-by: David Hildenbrand <david at redhat.com>

-- 

Thanks,

David