[PATCH v2 3/5] powerpc/mce: Hookup derror (load/store) UE errors

Nicholas Piggin npiggin at gmail.com
Wed Sep 13 16:21:13 AEST 2017


On Wed, 13 Sep 2017 16:10:47 +1000
Balbir Singh <bsingharora at gmail.com> wrote:

> Extract physical_address for UE errors by walking the page
> tables for the mm and address at the NIP, to extract the
> instruction. Then use the instruction to find the effective
> address via analyse_instr().
> 
> We might have page table walking races, but we expect them to
> be rare, the physical address extraction is best effort. The idea
> is to then hook up this infrastructure to memory failure eventually.

This all looks pretty good to me, you can probably update these
changelogs now because you are hooking it into memory failure.

I wonder if it would be worth skipping the instruction analysis and
page table walk if we've recursed up to the maximum MCE depth, just
in case we're hitting MCEs in part of that code or data.

Thanks,
Nick


More information about the Linuxppc-dev mailing list