[PATCH 2/2] powerpc/perf/imc: use NUMA_NO_NODE for alloc_pages_node

[Madhavan Srinivasan]

On Monday 16 October 2017 07:48 AM, Balbir Singh wrote:
> On Mon, 16 Oct 2017 00:13:42 +0530
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> wrote:
>
>> alloc_pages_node() when passed NUMA_NO_NODE for the
>> node_id, could get memory from closest node. Cleanup
>> core imc and thread imc memory init functions to use
>> NUMA_NO_NODE.
>
> The changelog is not clear, alloc_pages_node() takes a
> preferred node id and creates a node zonelist from it.
> How is NUMA_NO_NODE better?

IIUC with NUMA_NO_NODE we could remove the __GFP_NOWARN
for alloc_pages_node(). That said, one must be careful to make
sure we dont end up allocating memory from the boot cpu.
And incase of In Memory Collection (IMC) counters, it is handled
in the cpu online path.

Will send a v2 with __GFP_NOWARN removed which
I missed in this :)  .

Maddy

> Balbir Singh.
>