[PATCH v5] powerpc/vdso64: Add support for CLOCK_{REALTIME/MONOTONIC}_COARSE

Santosh Sivaraj santosh at fossix.org
Thu Oct 12 15:33:17 AEDT 2017


* Segher Boessenkool <segher at kernel.crashing.org> wrote (on 2017-10-11 17:02:16 +0000):

Hi Segher,
> Hi,
> 
> On Wed, Oct 11, 2017 at 02:05:02PM +0530, Santosh Sivaraj wrote:
> > +70:	ld      r8,CFG_TB_UPDATE_COUNT(r3)
> > +	andi.   r0,r8,1                 /* pending update ? loop */
> > +	bne-    70b
> > +	xor     r0,r8,r8                /* create dependency */
> 
> r0 already is 0 here, and already depends on r8.  Or is this trying
> to do something else?

The function from which this piece was borrowed from had a similar
implementation, didn't figure out why the extra dependency, kept it the way it
was. See __do_get_tspec function in the same file
(arch/powerpc/kernel/vdso64/gettimeofday.S).

> 
> > +	add     r3,r3,r0
> 
> 
> Segher

-- 


More information about the Linuxppc-dev mailing list