[PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

Arnd Bergmann arnd at arndb.de
Thu Oct 5 19:59:12 AEDT 2017


On Thu, Oct 5, 2017 at 1:27 AM, Kees Cook <keescook at chromium.org> wrote:
> Drop the arguments from the macro and adjust all callers with the
> following script:
>
>   perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
>     $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)
>
> Signed-off-by: Kees Cook <keescook at chromium.org>
> Acked-by: Geert Uytterhoeven <geert at linux-m68k.org> # for m68k parts

I was slightly worried about this large-scale rework, since it might conflict
with new users of DEFINE_TIMER(), causing bisection problems.

However, a little research showed that we have only added two users
in the past five years, so this is not a real concern.

for arch/arm, drivers/char and overall:

Acked-by: Arnd Bergmann <arnd at arndb.de>


More information about the Linuxppc-dev mailing list