[RFC 0/2] Consolidate patch_instruction

LEROY Christophe christophe.leroy at c-s.fr
Wed May 17 17:04:26 AEST 2017


Balbir Singh <bsingharora at gmail.com> a écrit :

> On Tue, 2017-05-16 at 22:20 +0200, LEROY Christophe wrote:
>> Balbir Singh <bsingharora at gmail.com> a écrit :
>>
>> > patch_instruction is enhanced in this RFC to support
>> > patching via a different virtual address (text_poke_area).
>> > The mapping of text_poke_area->addr is RW and not RWX.
>> > This way the mapping allows write for patching and then we tear
>> > down the mapping. The downside is that we introduce a spinlock
>> > which serializes our patching to one patch at a time.
>>
>> Very nice patch, would fit great with my patch for impmementing
>> CONFIG_DEBUG_RODATA (https://patchwork.ozlabs.org/patch/754289 ).
>> Would avoid having to set the text area back to RW for patching
>>
>
> Awesome! It seems like you have some of the work for CONFIG_STRICT_KERNEL_RWX
> any reason why this is under CONFIG_DEBUG_RODATA? But I think there is
> reuse capability across the future patches and the current set.
>

Indeed it looks the same, see https://patchwork.kernel.org/patch/9554881

Christophe


> Cheers,
> Balbir  Singh.




More information about the Linuxppc-dev mailing list