[PATCH 1/2] powerpc/tm: Fix FP and VMX register corruption

Michael Ellerman mpe at ellerman.id.au
Mon May 15 19:23:44 AEST 2017


Cyril Bur <cyrilbur at gmail.com> writes:

> On Mon, 2017-05-08 at 17:16 +1000, Michael Neuling wrote:
>> In this commit:
>>   commit dc3106690b20305c3df06b42456fe386dd632ac9
>>   Author: Cyril Bur <cyrilbur at gmail.com>
>>   powerpc: tm: Always use fp_state and vr_state to store live registers
>> 
>> A section of code was removed that copied the current state to
>> checkpointed state.  This should not have been removed.
>> 
>
> -[space]
>
>> When an FP unavailable is taken inside a transaction, we need to abort
>> the transaction. This is because at the time of the tbegin, the FP
>> state is bogus so the state stored in the checkpointed registers is
>> incorrect. To fix this, we treclaim (to get the checkpointed GPRs) and
>> then copy the thread_struct FP live state into the checkpointed
>> state. We then trecheckpoint so that the FP state is correctly
>> restored into the CPU.
>> 
>> The coping of the FP registers from live to checkpointed is what was
          ^
Missed the actual spelling error.

8D

cheers


More information about the Linuxppc-dev mailing list