[PATCH 3/3] powerpc/8xx: xmon compile fix
Nicholas Piggin
npiggin at gmail.com
Fri May 12 05:30:52 AEST 2017
On Thu, 11 May 2017 20:52:56 +0200
christophe leroy <christophe.leroy at c-s.fr> wrote:
> Le 11/05/2017 à 19:14, christophe leroy a écrit :
> >
> >
> > Le 11/05/2017 à 17:15, Nicholas Piggin a écrit :
> >> Cc: Scott Wood <oss at buserror.net>
> >> Cc: Christophe Leroy <christophe.leroy at c-s.fr>
> >> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> >> ---
> >> arch/powerpc/xmon/xmon.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> >> index f11f65634aab..ec420b0e6e88 100644
> >> --- a/arch/powerpc/xmon/xmon.c
> >> +++ b/arch/powerpc/xmon/xmon.c
> >> @@ -1242,10 +1242,13 @@ bpt_cmds(void)
> >> {
> >> int cmd;
> >> unsigned long a;
> >> - int mode, i;
> >> + int i;
> >> struct bpt *bp;
> >> +#ifndef CONFIG_8xx
> >
> > Would be better to use CONFIG_PPC_8xx
> >
> > As stated in arch/powerpc/platform/Kconfig.cputype, CONFIG_8xx is temp
> > to handle compat with arch/ppc, and we are trying to get rid of it
>
> I had the same comment in https://patchwork.ozlabs.org/patch/700354/
> I also suggested to move the relevant declarations inside the switch()
Apologies, you did. I was just cleaning out an old backlog of
patches and I forgot about your comments. Sorry, I'll resend
the patch.
Thanks,
Nick
More information about the Linuxppc-dev
mailing list