[PATCH] cxl: Unlock on error in probe

Dan Carpenter dan.carpenter at oracle.com
Fri May 5 17:39:07 AEST 2017


On Fri, May 05, 2017 at 09:23:02AM +0200, walter harms wrote:
> > sem is a global and it looks like it's intended to be held after
> > device_open() returns and only released in device_close(), so this looks
> > wrong.
> > 
> 
> the patch relates to the error path, do you expect a close() after the open() failed ?
> 

You can't close if open fails.  Please don't ask rhetorical questions.
Just state everything in short sentences using simple words.

regards,
dan carpenter



More information about the Linuxppc-dev mailing list