[PATCH 1/3] cxl: Re-factor cxl_pci_afu_read_err_buffer()

Vaibhav Jain vaibhav at linux.vnet.ibm.com
Tue Mar 21 15:38:56 AEDT 2017


Thanks for reviewing Andrew !!

Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:

>> +
>> +	/* max we can copy in one read is PAGE_SIZE */
>> +	if (aligned_length > ERR_BUFF_MAX_COPY_SIZE) {
>
> I'm not sure if the name ERR_BUFF_MAX_COPY_SIZE makes sense here any
> more.

It might make sense to change to PAGE_SIZE. Will do the change in
susequent revision.

-- 
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.



More information about the Linuxppc-dev mailing list