[PATCH] crypto: powerpc - Fix initialisation of crc32c context

Michael Ellerman mpe at ellerman.id.au
Mon Mar 6 15:43:31 AEDT 2017


Daniel Axtens <dja at axtens.net> writes:

> Turning on crypto self-tests on a POWER8 shows:
>
>     alg: hash: Test 1 failed for crc32c-vpmsum
>     00000000: ff ff ff ff
>
> Comparing the code with the Intel CRC32c implementation on which
> ours is based shows that we are doing an init with 0, not ~0
> as CRC32c requires.
>
> This probably wasn't caught because btrfs does its own weird
> open-coded initialisation.
>
> Initialise our internal context to ~0 on init.
>
> This makes the self-tests pass, and btrfs continues to work.
>
> Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
> Cc: Anton Blanchard <anton at samba.org>
> Cc: stable at vger.kernel.org
> Signed-off-by: Daniel Axtens <dja at axtens.net>
> ---
>  arch/powerpc/crypto/crc32c-vpmsum_glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This driver was originally merged via the crypto tree, so I'll assume
Herbert will pick up the fix. If he hasn't in a few days I'll take it.

cheers


More information about the Linuxppc-dev mailing list