[RESEND-RFC v2 2/3] powerpc/eeh: Introduce function eeh_pe_reset_freeze_counter()

Andrew Donnellan andrew.donnellan at au1.ibm.com
Fri Mar 3 15:39:57 AEDT 2017


On 03/03/17 15:35, Russell Currey wrote:
> I thought about this but figured it didn't really make sense from a CAPI
> perspective.  If you're flashing the device, it is going to have different
> behaviour to before it was flashed, and that it should be treated differently as
> a result (and thus restoring the freeze_count doesn't make much sense).
>
> Consider a case where there's a buggy FPGA image on an adapter that's failed 4
> times in the past hour, and generally has frequent errors.  You decide to update
> it to something that's less buggy, so you flash the adapter.  The freeze_count
> gets cached and thus is restored to 4 after the flash.  Now even if the new
> image is less buggy and may only fail once an hour instead of multiple times, if
> it happens to fail within an hour of the earlier failures the device is now
> fenced and you need to reboot.
>
> I don't mind either way - I just don't get the logic of restoring the count.

I agree with this logic.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Linuxppc-dev mailing list