[PATCH v3 1/2] powerpc: split ftrace bits into a separate file

Michael Ellerman mpe at ellerman.id.au
Thu Mar 2 20:38:53 AEDT 2017


Steven Rostedt <rostedt at goodmis.org> writes:

> On Tue, 28 Feb 2017 15:04:15 +1100
> Michael Ellerman <mpe at ellerman.id.au> wrote:
>
> kernel/trace/ftrace.c more obvious.
>> 
>> I don't know if it's really worth keeping the names the same across
>> arches, especially as we already have:
>> 
>>   arch/arm64/kernel/entry-ftrace.S
>>   arch/arm/kernel/entry-ftrace.S
>>   arch/blackfin/kernel/ftrace-entry.S
>>   arch/metag/kernel/ftrace_stub.S
>> 
>> But we can rename it if you feel strongly about it.
>
> Hmm, perhaps "entry-ftrace.S" would be the better name. I never liked
> the "mcount.S" name.

Except what does the "entry" part mean?

Traditionally entry.S has been for the code that "enters" the kernel,
ie. from userspace or elsewhere. But that's not the case with any of the
ftrace code, it's kernel code called from the kernel. So using "entry"
is a bit wrong IMHO.

So if we drop that we're left with ftrace.S - which seems perfect to me.

cheers


More information about the Linuxppc-dev mailing list