[PATCH] powerpc: remapping too much memory

Michael Ellerman mpe at ellerman.id.au
Thu Jun 29 15:26:14 AEST 2017


Dan Carpenter <dan.carpenter at oracle.com> writes:

> There is a cut and paste error here so we use "sizeof(struct mpc83xx_pmc)"
> to remap the memory for "clock_regs".  That sizeof() is 20 bytes and we
> only need to remap 12 bytes.  It presumably doesn't affect run time too
> much...

I don't know 83xx well, but I suspect mappings occur on a 4K granularity
at a minimum :)

> I changed them to both use "sizeof(*variable_name)" because that's the
> prefered kernel style these days.

Thanks.

cheers


More information about the Linuxppc-dev mailing list