linux-next: build failure after merge of the block tree

Stephen Rothwell sfr at canb.auug.org.au
Thu Jun 29 07:33:22 AEST 2017


Hi Jens,

On Wed, 28 Jun 2017 09:11:32 -0600 Jens Axboe <axboe at kernel.dk> wrote:
>
> On 06/28/2017 08:01 AM, Jens Axboe wrote:
> > But put_user() is fine? Just checking here, since the change adds
> > both a u64 put and get user.  

Yes, put_user is fine (it does 2 4 byte moves.  The asm is there to do
the 8 byte get_user, but the surrounding C code uses an unsigned long
for the destination in all cases (some other arches do the same).  I
don't remember why it is like that.

> I just changed all 4, at least that provides some symmetry in how
> we copy things in and out for that set of fcntls.

OK, thanks.

-- 
Cheers,
Stephen Rothwell


More information about the Linuxppc-dev mailing list