[PATCH] fsl/fman: add dependency on HAS_DMA

Madalin-cristian Bucur madalin.bucur at nxp.com
Tue Jun 27 16:26:25 AEST 2017


> -----Original Message-----
> From: geert.uytterhoeven at gmail.com [mailto:geert.uytterhoeven at gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: Monday, June 26, 2017 7:17 PM
> To: Fabio Estevam <festevam at gmail.com>
> Cc: Madalin-cristian Bucur <madalin.bucur at nxp.com>;
> netdev at vger.kernel.org; David S. Miller <davem at davemloft.net>; linuxppc-
> dev at lists.ozlabs.org; linux-kernel <linux-kernel at vger.kernel.org>
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
> 
> On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam at gmail.com> wrote:
> > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur at nxp.com>
> wrote:
> >> A previous commit inserted a dependency on DMA API that requires
> >> HAS_DMA to be added in Kconfig.
> >
> > It would be nice to specify the commit that caused this.
> 
> That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").
> 
> However, none of the fman code uses any DMA API calls, so IMHO
> the set_dma_ops() should be done somewhere else.

The Ethernet driver is making use of the DMA ops set here.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds


More information about the Linuxppc-dev mailing list