[PATCH 25/44] arm: implement ->mapping_error
Christoph Hellwig
hch at lst.de
Fri Jun 16 18:43:28 AEST 2017
On Thu, Jun 08, 2017 at 03:43:14PM +0100, Russell King - ARM Linux wrote:
> BOn Thu, Jun 08, 2017 at 03:25:50PM +0200, Christoph Hellwig wrote:
> > +static int dmabounce_mapping_error(struct device *dev, dma_addr_t dma_addr)
> > +{
> > + if (dev->archdata.dmabounce)
> > + return 0;
>
> I'm not convinced that we need this check here:
>
> dev->archdata.dmabounce = device_info;
> set_dma_ops(dev, &dmabounce_ops);
>
> There shouldn't be any chance of dev->archdata.dmabounce being NULL if
> the dmabounce_ops has been set as the current device DMA ops. So I
> think that test can be killed.
Ok, I'll fix it up.
More information about the Linuxppc-dev
mailing list