[PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

David Miller davem at davemloft.net
Tue Jun 13 00:59:05 AEST 2017


From: David Miller <davem at davemloft.net>
Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT)

> From: Yuval Shaia <yuval.shaia at oracle.com>
> Date: Mon, 12 Jun 2017 17:15:08 +0300
> 
>> Make return value void since function never return meaningfull value
>> 
>> Signed-off-by: Yuval Shaia <yuval.shaia at oracle.com>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>> ---
>> v0 ->v1:
>> 	* These files were missing in v0
>> 		* drivers/net/ethernet/renesas/ravb_main.c
>> 		* drivers/net/ethernet/renesas/sh_eth.c
>> 		* drivers/net/ethernet/ti/netcp_ethss.c
>> 	* Add Acked-by: Sergei Shtylyov
>> v1 -> v2:
>> 	* Adjust to net-next tree
> 
> Applied, thank you.

Reverted, please test your build properly:

drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c: In function ‘xgene_get_link_ksettings’:
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:134:10: error: void value not ignored as it ought to be
   return phy_ethtool_ksettings_get(phydev, cmd);
          ^
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:140:11: error: void value not ignored as it ought to be
    return phy_ethtool_ksettings_get(phydev, cmd);
           ^
scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.o' failed


More information about the Linuxppc-dev mailing list