powerpc/opal-irqchip: Use interrupt names if present

Geert Uytterhoeven geert at linux-m68k.org
Sun Jun 4 00:04:44 AEST 2017


Hi Ben,

On Fri, Jun 2, 2017 at 4:11 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Fri, 2017-06-02 at 14:39 +0200, Geert Uytterhoeven wrote:
>> > diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c
>> > index 998316bf2dad..ecdcba9d1220 100644
>> > --- a/arch/powerpc/platforms/powernv/opal-irqchip.c
>> > +++ b/arch/powerpc/platforms/powernv/opal-irqchip.c
>> > @@ -183,8 +183,9 @@ void opal_event_shutdown(void)
>> > +       /* It's not an error for the names to be missing */
>> > +       of_property_read_string_array(opal_node, "opal-interrupts-names",
>> > +                                     names, opal_irq_count);
>>
>> Just double-checking, as it's different from the standard "interrupt-names":
>> is "opal-interrupts-names" the correct name?
>
> Yes, because the property it refers to isn't a standard "interrupts"
> property... it's ... complicated :-)

I'm aware it's a different property.

> It could have been mind you, but the decision for that was made years
> ago... it's a bunch of interrupts OPAL is interested in, which Linux
> requests and sets up a handler for which just calls back into OPAL.
>
> In any case, firmwares with that property are out now.

Thanks for the confirmation!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the Linuxppc-dev mailing list