[PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove

Michael Ellerman mpe at ellerman.id.au
Tue Jul 25 14:47:48 AEST 2017

Tyrel Datwyler <turtle.in.the.kernel at gmail.com> writes:

> On 07/24/2017 03:42 AM, Michael Ellerman wrote:
>> Laurent Vivier <lvivier at redhat.com> writes:
>>> As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
>>> underflow during DLPAR remove"), the call to of_node_put()
>>> must be removed from pSeries_reconfig_remove_node().
>>> dlpar_detach_node() and pSeries_reconfig_remove_node() call
>>> of_detach_node(), and thus the node should not be released
>>> in this case too.
>>> Signed-off-by: Laurent Vivier <lvivier at redhat.com>
>>> ---
>>>  arch/powerpc/platforms/pseries/reconfig.c | 1 -
>>>  1 file changed, 1 deletion(-)
>> Thanks. I'll spare you the swearing about why we have the same bug in
>> two places.
> That's probably my bad. I must have failed to test with older powerpc-util tooling where
> drmgr uses the /proc/ofdt interface for device tree modification.

OK. Really we should have automated tests of the various cases, I've
just never had time to write any.

Mainly the thing that bugs me is that we still have the two separate
paths. Or if we must maintain both they could at least share more code,
the two functions do basically the same thing AFAICS.


More information about the Linuxppc-dev mailing list