[PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params
matthew.brown.dev at gmail.com
Mon Jul 24 14:31:09 AEST 2017
I've realised that changing the arguments for the cacheflush functions
is much more work than its worth, due to other archs using these
The next patch will just translate the asm cacheflush functions to c,
keeping the existing parameters.
So this won't have any effect on the drivers.
On Thu, Jul 20, 2017 at 11:01 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> Geert Uytterhoeven <geert at linux-m68k.org> writes:
>> On Thu, Jul 20, 2017 at 1:43 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
>>> Matt Brown <matthew.brown.dev at gmail.com> writes:
>>>> The cacheflush prototypes currently use start and stop values and each
>>>> call requires typecasting the address to an unsigned long.
>>>> This patch changes the cacheflush prototypes to follow the x86 style of
>>>> using a base and size values, with base being a void pointer.
>>>> All callers of the cacheflush functions, including drivers, have been
>>>> modified to conform to the new prototypes.
>>>> The 64 bit cacheflush functions which were implemented in assembly code
>>>> (flush_dcache_range, flush_inval_dcache_range) have been translated into
>>>> C for readability and coherence.
>>>> --- a/arch/powerpc/include/asm/cacheflush.h
>>>> +++ b/arch/powerpc/include/asm/cacheflush.h
>>>> @@ -51,13 +51,13 @@ static inline void __flush_dcache_icache_phys(unsigned long physaddr)
>>>> * Write any modified data cache blocks out to memory and invalidate them.
>>>> * Does not invalidate the corresponding instruction cache blocks.
>>>> -static inline void flush_dcache_range(unsigned long start, unsigned long stop)
>>>> +static inline void flush_dcache_range(void *start, unsigned long size)
>>>> - void *addr = (void *)(start & ~(L1_CACHE_BYTES - 1));
>>>> - unsigned long size = stop - (unsigned long)addr + (L1_CACHE_BYTES - 1);
>>>> + void *addr = (void *)((u32)start & ~(L1_CACHE_BYTES - 1));
>>> unsigned long would be nicer than u32.
>> Indeed. That would make this work on ppc64, too.
>> After which ppc64 has an identical copy (u64 = unsigned long on ppc64) below?
> That was Matt's homework to notice that ;)
More information about the Linuxppc-dev