powerpc/powernv: Fix boot on Power8 bare metal due to opal_configure_cores()

Michael Ellerman patch-notifications at ellerman.id.au
Tue Jul 18 20:26:12 AEST 2017

On Mon, 2017-07-17 at 11:31:00 UTC, Michael Ellerman wrote:
> In commit 1c0eaf0f56d6 ("powerpc/powernv: Tell OPAL about our MMU mode
> on POWER9"), we added additional flags to the OPAL call to configure
> CPUs at boot.
> These flags only work on Power9 firmwares, and worse can cause boot
> failures on Power8 machines, so we check for CPU_FTR_ARCH_300 (aka POWER9)
> before adding the extra flags.
> Unfortunately we forgot that opal_configure_cores() is called before
> the CPU feature checks are dynamically patched, meaning the check
> always returns true.
> We definitely need to do something to make the CPU feature checks less
> prone to bugs like this, but for now the minimal fix is to use
> early_cpu_has_feature().
> Reported-and-tested-by: Abdul Haleem <abdhalee at linux.vnet.ibm.com>
> Fixes: 1c0eaf0f56d6 ("powerpc/powernv: Tell OPAL about our MMU mode on POWER9")
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> Acked-by: Balbir Singh <bsingharora at gmail.com>

Applied to powerpc fixes.



More information about the Linuxppc-dev mailing list