[PATCH v3 03/10] mtd: powernv_flash: Don't treat OPAL_SUCCESS as an error
cyrilbur at gmail.com
Tue Jul 18 10:42:15 AEST 2017
On Mon, 2017-07-17 at 18:50 +1000, Balbir Singh wrote:
> On Wed, 2017-07-12 at 14:22 +1000, Cyril Bur wrote:
> > While this driver expects to interact asynchronously, OPAL is well
> > within its rights to return OPAL_SUCCESS to indicate that the operation
> > completed without the need for a callback. We shouldn't treat
> > OPAL_SUCCESS as an error rather we should wrap up and return promptly to
> > the caller.
> > Signed-off-by: Cyril Bur <cyrilbur at gmail.com>
> > ---
> > I'll note here that currently no OPAL exists that will return
> > OPAL_SUCCESS so there isn't the possibility of a bug today.
> It would help if you mentioned OPAL_SUCCESS to the async call. So effectively
> what we expected to be an asynchronous call with callback, but OPAL returned
> immediately with success.
Ah my favourite problems, commit message.
> Balbir Singh.
More information about the Linuxppc-dev