[PATCH 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

Andrew Donnellan andrew.donnellan at au1.ibm.com
Thu Jul 13 13:51:30 AEST 2017


On 13/07/17 13:25, Matt Brown wrote:
> @@ -1049,6 +1066,13 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
>  			do_cmp_unsigned(regs, val, val2, rd >> 2);
>  			goto instr_done;
>
> +		case 19173952: /* cmpb */

This looks wrong and should never trigger, given that the switch 
statement is comparing against ((instr >> 1) & 0x3ff).

How did you get this value?

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Linuxppc-dev mailing list