[PATCH v5 2/2] powerpc/fadump: update documentation about 'fadump_append=' parameter
hbathini at linux.vnet.ibm.com
Wed Jul 12 22:15:07 AEST 2017
On Wednesday 12 July 2017 05:01 PM, msuchanek wrote:
> On Wed, 12 Jul 2017 00:00:57 +0530
> Hari Bathini <hbathini at linux.vnet.ibm.com> wrote:
>> Hi Michal,
>> Thanks for the review..
>> On Monday 26 June 2017 05:45 PM, Michal Suchánek wrote:
>>> On Tue, 20 Jun 2017 21:14:08 +0530
>>> Hari Bathini <hbathini at linux.vnet.ibm.com> wrote:
>> I would prefer documenting over a complex implementation. Actually, I
>> am considering a simple approach of replacing every occurrence of
>> "fadump_extra_args=" with "fadump_extra_args " in fadump capture
>> kernel. The cmdline
>> "root=/dev/sda2 ro fadump_extra_args="a b c" crashkernel=512M
>> "root=/dev/sda2 ro fadump_extra_args "a b c" crashkernel=512M
>> fadump_extra_args d"
> which is totally broken
My bad! I don't know what I was thinking when I expected that to work.. :-[
>> in fadump capture kernel. This must take care of the pitfalls with
>> the current approach and also,
>> doesn't rely on parse_args() which was not designed for this scenario
>> to start with..?
> It was designed for parsing arguments. To handle replacing arguments
> you have to extend it. You need to get more information from it for
> this case.
I will try to work on this. Also, want to replace in-place without
moving other parameters.
I guess, I could do that by replacing the leftover length after
processing with spaces..
More information about the Linuxppc-dev