[PATCH v5 1/4] powerpc/mm: refactor radix physical page mapping

Reza Arbab arbab at linux.vnet.ibm.com
Tue Jan 31 04:28:03 AEDT 2017


On Mon, Jan 30, 2017 at 07:38:18PM +1100, Michael Ellerman wrote:
>Doesn't build.
>
>In file included from ../include/linux/kernel.h:13:0,
>                 from ../include/linux/sched.h:17,
>                 from ../arch/powerpc/mm/pgtable-radix.c:11:
>../arch/powerpc/mm/pgtable-radix.c: In function ‘create_physical_mapping’:
>../include/linux/printk.h:299:2: error: ‘mapping_size’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>  ^~~~~~
>../arch/powerpc/mm/pgtable-radix.c:123:22: note: ‘mapping_size’ was declared here
>  unsigned long addr, mapping_size;

Doh. Could you please do the following for now?

-	unsigned long addr, mapping_size;
+	unsigned long addr, mapping_size = 0;

I'd like to delay spinning v6 with this until I see any input you might 
have on the rest of the set.

And for future reference, how are you ending up with 
-Werror=maybe-uninitialized? On powerpc/next, with pseries_le_defconfig, 
I get -Wno-maybe-uninitialized.

-- 
Reza Arbab



More information about the Linuxppc-dev mailing list