[PATCH net 1/5] ibmvnic: harden interrupt handler

David Miller davem at davemloft.net
Thu Jan 26 15:04:13 AEDT 2017


From: Thomas Falcon <tlfalcon at linux.vnet.ibm.com>
Date: Wed, 25 Jan 2017 15:02:19 -0600

> Move most interrupt handler processing into a tasklet, and
> introduce a delay after re-enabling interrupts to fix timing
> issues encountered in hardware testing.
> 
> Signed-off-by: Thomas Falcon <tlfalcon at linux.vnet.ibm.com>

I don't think you have any idea what the real problem is.  This looks
like a hack, at best.  Next patch you'll increase the delay to "20",
right?  And if that doesn't work you'll try "40".

Or if you do know the reason, you need to explain it in detail in this
commit message so that we can properly evaluate this patch.

Furthermore, if you're going to move all of your packet processing
into software interrupt context, you might as well use NAPI polling
which is a purposefully built piece of infrastructure for doing
exactly this.



More information about the Linuxppc-dev mailing list