powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()

SF Markus Elfring elfring at users.sourceforge.net
Fri Jan 20 18:08:55 AEDT 2017

> I think you really could have squashed patches 1-3 into a single patch
> that returns directly after any failure.

Thanks for your constructive feedback.

I have got software development concerns around such patch squashing.

> At this point you might as well remove that label and move the kfree(tmp) call up
> and return directly after the failure and at the nvram_write() call site
> doing away completely with the "ret" variable.

Your idea might look nice at first glance. But I would interpret the previous
implementation of the discussed function in the way that the memory which was
dynamically allocated here should always (not only in the failure case) be released
before returning here.

Would you really like to change the life time for this “temporary” data item?


More information about the Linuxppc-dev mailing list