[PATCH v4 09/15] livepatch: remove unnecessary object loaded check

Josh Poimboeuf jpoimboe at redhat.com
Fri Jan 20 02:46:17 AEDT 2017


klp_patch_object()'s callers already ensure that the object is loaded,
so its call to klp_is_object_loaded() is unnecessary.

This will also make it possible to move the patching code into a
separate file.

Signed-off-by: Josh Poimboeuf <jpoimboe at redhat.com>
Acked-by: Miroslav Benes <mbenes at suse.cz>
Reviewed-by: Petr Mladek <pmladek at suse.com>
Reviewed-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
---
 kernel/livepatch/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 2dbd355..47ed643 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -467,9 +467,6 @@ static int klp_patch_object(struct klp_object *obj)
 	if (WARN_ON(obj->patched))
 		return -EINVAL;
 
-	if (WARN_ON(!klp_is_object_loaded(obj)))
-		return -EINVAL;
-
 	klp_for_each_func(obj, func) {
 		ret = klp_patch_func(func);
 		if (ret) {
-- 
2.7.4



More information about the Linuxppc-dev mailing list