[PATCH] powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe()

Gavin Shan gwshan at linux.vnet.ibm.com
Wed Jan 11 14:16:49 AEDT 2017


In __eeh_clear_pe_frozen_state(), we should pass the flag's value
instead of its address to eeh_unfreeze_pe(). This doesn't introduce
any problems, but the code is just wrong.

This fixes the code by passing flag's value to eeh_unfreeze_pe().

Cc: stable at vger.kernel.org #3.18+
Fixes: 5cfb20b96f6 ("powerpc/eeh: Emulate EEH recovery for VFIO devices")
Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
---
 arch/powerpc/kernel/eeh_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
index d88573b..fa15fa6 100644
--- a/arch/powerpc/kernel/eeh_driver.c
+++ b/arch/powerpc/kernel/eeh_driver.c
@@ -549,7 +549,7 @@ static void *__eeh_clear_pe_frozen_state(void *data, void *flag)
 	int i, rc = 1;
 
 	for (i = 0; rc && i < 3; i++)
-		rc = eeh_unfreeze_pe(pe, clear_sw_state);
+		rc = eeh_unfreeze_pe(pe, *clear_sw_state);
 
 	/* Stop immediately on any errors */
 	if (rc) {
-- 
2.7.4



More information about the Linuxppc-dev mailing list