[PATCH 3/4] cxlflash: Cleanup prints

Andrew Donnellan andrew.donnellan at au1.ibm.com
Mon Jan 9 17:50:19 AEDT 2017


On 07/01/17 01:05, Uma Krishnan wrote:
> From: "Matthew R. Ochs" <mrochs at linux.vnet.ibm.com>
>
> The usage of prints within the cxlflash driver is inconsistent. This
> hinders debug and makes the driver source and log output appear sloppy.
>
> The following cleanups help unify the prints within cxlflash:
>  - move all prints to dev-* where possible
>  - transition all hex prints to lowercase
>  - standardize variable prints in debug output
>  - derive pointers in a consistent manner
>  - remove superfluous data from prints and print statements that do not
>    make sense

And change a couple of ints to bools, which isn't strictly print-related. :)

>
> Signed-off-by: Matthew R. Ochs <mrochs at linux.vnet.ibm.com>

An impressive cleanup! Nothing bad which stands out to me.

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Linuxppc-dev mailing list