[PATCH v2 1/2] powerpc/perf: Factor out bhrb functions
Madhavan Srinivasan
maddy at linux.vnet.ibm.com
Thu Jan 5 23:37:52 AEDT 2017
Factor out the bhrb functions to "isa207-common.c"
to share with power9 DD1. Only code movement and no logic change
Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>
---
Changelog v1:
1)Updates to commit messages
arch/powerpc/perf/isa207-common.c | 41 ++++++++++++++++++++++++++++++++
arch/powerpc/perf/isa207-common.h | 9 +++++++
arch/powerpc/perf/power8-pmu.c | 49 ++-------------------------------------
arch/powerpc/perf/power9-pmu.c | 4 ++--
4 files changed, 54 insertions(+), 49 deletions(-)
diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c
index 50e598cf644b..ee4e3e89c04c 100644
--- a/arch/powerpc/perf/isa207-common.c
+++ b/arch/powerpc/perf/isa207-common.c
@@ -338,3 +338,44 @@ void isa207_disable_pmc(unsigned int pmc, unsigned long mmcr[])
if (pmc <= 3)
mmcr[1] &= ~(0xffUL << MMCR1_PMCSEL_SHIFT(pmc + 1));
}
+
+u64 isa207_bhrb_filter_map(u64 branch_sample_type)
+{
+ u64 pmu_bhrb_filter = 0;
+
+ /* BHRB and regular PMU events share the same privilege state
+ * filter configuration. BHRB is always recorded along with a
+ * regular PMU event. As the privilege state filter is handled
+ * in the basic PMC configuration of the accompanying regular
+ * PMU event, we ignore any separate BHRB specific request.
+ */
+
+ /* No branch filter requested */
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY)
+ return pmu_bhrb_filter;
+
+ /* Invalid branch filter options - HW does not support */
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_RETURN)
+ return -1;
+
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_IND_CALL)
+ return -1;
+
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_CALL)
+ return -1;
+
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_CALL) {
+ pmu_bhrb_filter |= MMCRA_IFM1;
+ return pmu_bhrb_filter;
+ }
+
+ /* Every thing else is unsupported */
+ return -1;
+}
+
+void isa207_config_bhrb(u64 pmu_bhrb_filter)
+{
+ /* Enable BHRB filter in PMU */
+ mtspr(SPRN_MMCRA, (mfspr(SPRN_MMCRA) | pmu_bhrb_filter));
+}
+
diff --git a/arch/powerpc/perf/isa207-common.h b/arch/powerpc/perf/isa207-common.h
index 90495f1580c7..e5e4182731da 100644
--- a/arch/powerpc/perf/isa207-common.h
+++ b/arch/powerpc/perf/isa207-common.h
@@ -244,6 +244,12 @@
#define MMCRA_SDAR_MODE_TLB (1ull << MMCRA_SDAR_MODE_SHIFT)
#define MMCRA_IFM_SHIFT 30
+/* MMCRA IFM bits */
+#define MMCRA_IFM1 0x0000000040000000UL
+#define MMCRA_IFM2 0x0000000080000000UL
+#define MMCRA_IFM3 0x00000000C0000000UL
+
+
/* MMCR1 Threshold Compare bit constant for power9 */
#define p9_MMCRA_THR_CMP_SHIFT 45
@@ -261,4 +267,7 @@ int isa207_compute_mmcr(u64 event[], int n_ev,
struct perf_event *pevents[]);
void isa207_disable_pmc(unsigned int pmc, unsigned long mmcr[]);
+u64 isa207_bhrb_filter_map(u64 branch_sample_type);
+void isa207_config_bhrb(u64 pmu_bhrb_filter);
+
#endif
diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c
index d07186382f3a..91120bec4173 100644
--- a/arch/powerpc/perf/power8-pmu.c
+++ b/arch/powerpc/perf/power8-pmu.c
@@ -25,11 +25,6 @@ enum {
#undef EVENT
-/* MMCRA IFM bits - POWER8 */
-#define POWER8_MMCRA_IFM1 0x0000000040000000UL
-#define POWER8_MMCRA_IFM2 0x0000000080000000UL
-#define POWER8_MMCRA_IFM3 0x00000000C0000000UL
-
/* PowerISA v2.07 format attribute structure*/
extern struct attribute_group isa207_pmu_format_group;
@@ -195,46 +190,6 @@ static int power8_generic_events[] = {
[PERF_COUNT_HW_CACHE_MISSES] = PM_LD_MISS_L1,
};
-static u64 power8_bhrb_filter_map(u64 branch_sample_type)
-{
- u64 pmu_bhrb_filter = 0;
-
- /* BHRB and regular PMU events share the same privilege state
- * filter configuration. BHRB is always recorded along with a
- * regular PMU event. As the privilege state filter is handled
- * in the basic PMC configuration of the accompanying regular
- * PMU event, we ignore any separate BHRB specific request.
- */
-
- /* No branch filter requested */
- if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY)
- return pmu_bhrb_filter;
-
- /* Invalid branch filter options - HW does not support */
- if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_RETURN)
- return -1;
-
- if (branch_sample_type & PERF_SAMPLE_BRANCH_IND_CALL)
- return -1;
-
- if (branch_sample_type & PERF_SAMPLE_BRANCH_CALL)
- return -1;
-
- if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_CALL) {
- pmu_bhrb_filter |= POWER8_MMCRA_IFM1;
- return pmu_bhrb_filter;
- }
-
- /* Every thing else is unsupported */
- return -1;
-}
-
-static void power8_config_bhrb(u64 pmu_bhrb_filter)
-{
- /* Enable BHRB filter in PMU */
- mtspr(SPRN_MMCRA, (mfspr(SPRN_MMCRA) | pmu_bhrb_filter));
-}
-
#define C(x) PERF_COUNT_HW_CACHE_##x
/*
@@ -352,8 +307,8 @@ static struct power_pmu power8_pmu = {
.add_fields = ISA207_ADD_FIELDS,
.test_adder = ISA207_TEST_ADDER,
.compute_mmcr = isa207_compute_mmcr,
- .config_bhrb = power8_config_bhrb,
- .bhrb_filter_map = power8_bhrb_filter_map,
+ .config_bhrb = isa207_config_bhrb,
+ .bhrb_filter_map = isa207_bhrb_filter_map,
.get_constraint = isa207_get_constraint,
.get_alternatives = power8_get_alternatives,
.disable_pmc = isa207_disable_pmc,
diff --git a/arch/powerpc/perf/power9-pmu.c b/arch/powerpc/perf/power9-pmu.c
index 346010e8d463..56ad09801fff 100644
--- a/arch/powerpc/perf/power9-pmu.c
+++ b/arch/powerpc/perf/power9-pmu.c
@@ -380,8 +380,8 @@ static struct power_pmu power9_isa207_pmu = {
.add_fields = ISA207_ADD_FIELDS,
.test_adder = ISA207_TEST_ADDER,
.compute_mmcr = isa207_compute_mmcr,
- .config_bhrb = power9_config_bhrb,
- .bhrb_filter_map = power9_bhrb_filter_map,
+ .config_bhrb = isa207_config_bhrb,
+ .bhrb_filter_map = isa207_bhrb_filter_map,
.get_constraint = isa207_get_constraint,
.disable_pmc = isa207_disable_pmc,
.flags = PPMU_HAS_SIER | PPMU_ARCH_207S,
--
2.7.4
More information about the Linuxppc-dev
mailing list