[PATCH] powerpc: fix pgtable pmd cache init

Aneesh Kumar K.V aneesh.kumar at linux.vnet.ibm.com
Wed Jan 4 13:18:21 AEDT 2017


Nicholas Piggin <npiggin at gmail.com> writes:

> On Wed, 04 Jan 2017 07:34:41 +0530
> "Aneesh Kumar K.V" <aneesh.kumar at linux.vnet.ibm.com> wrote:
>
>> Nicholas Piggin <npiggin at gmail.com> writes:
>> 
>> > Commit 9b081e10805cd ("powerpc: port 64 bits pgtable_cache to 32 bits")
>> > mixed up PMD_INDEX_SIZE and PMD_CACHE_INDEX a couple of times. This
>> > resulted in 64s/hash/4k configs to panic at boot with a false positive
>> > error check.
>> >
>> > Fix that and simplify error handling by moving the check to the caller.
>> >
>> > Fixes: 9b081e10805cd ("powerpc: port 64 bits pgtable_cache to 32 bits")
>> > Cc: Christophe Leroy <christophe.leroy at c-s.fr>
>> > Cc: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
>> > Cc: Scott Wood <oss at buserror.net>
>> > Cc: linuxppc-dev at lists.ozlabs.org
>> > Signed-off-by: Nicholas Piggin <npiggin at gmail.com>  
>> 
>> I did another fix here.
>> 
>> https://lkml.kernel.org/r/20161214043349.23677-1-aneesh.kumar@linux.vnet.ibm.com
>> 
>> But this patch makes it much simpler. Hence.
>> 
>> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
>> 
>> There is this hunk in the patch I did.
>
> Ah, I missed that. My patch just fixes the 9b081e10805cd bug, but this
> hunk looks like it should still go in as another patch. Will you resend
> it?
>

ok will do that.

-aneesh



More information about the Linuxppc-dev mailing list