[PATCH] cxl: Route eeh events to all slices for pci_channel_io_perm_failure state

Matthew R. Ochs mrochs at linux.vnet.ibm.com
Thu Feb 23 03:08:20 AEDT 2017


> On Feb 22, 2017, at 4:51 AM, Vaibhav Jain <vaibhav at linux.vnet.ibm.com> wrote:
> 
> Fix a boundary condition where in some cases an eeh event with
> state == pci_channel_io_perm_failure wont be passed on to a driver
> attached to the virtual pci device associated with a slice. This will
> happen in case the slice just before (n-1) doesn't have any vph bus
> associated with it, that results in an early return from
> cxl_pci_error_detected callback.
> 
> This also simplifies branch that handles this eeh state by returning
> PCI_ERS_RESULT_DISCONNECTED in all cases as the adapter is will be
> removed irrespective of the return value of cxl_pci_error_detected
> callback.

This sentence could be cleaned up a bit.

> 
> Fixes: e4f5fc001a6("cxl: Do not create vPHB if there are no AFU configuration records")
> Signed-off-by: Vaibhav Jain <vaibhav at linux.vnet.ibm.com>

Fix looks good!

Reviewed-by: Matthew R. Ochs <mrochs at linux.vnet.ibm.com>



More information about the Linuxppc-dev mailing list