[PATCH] powerpc: Fix inconsistent of_node_to_nid EXPORT_SYMBOL handling

[Shailendra Singh]

Hi Michael,

>>>Which was merged in May 2006. So the powerpc version has almost 10 years precedence.

 Agreed but keeping the licensing consistent will help drivers making seamless use of it on all architectures.

>>> But I guess it's a pretty boring API. So I'll merge this unless anyone else objects.
Thanks. Appreciate your quick response and help.

Thanks,
Shailendra

-----Original Message-----
From: Michael Ellerman [mailto:mpe at ellerman.id.au] 
Sent: Thursday, February 09, 2017 4:19 AM
To: Shailendra Singh <shailendras at nvidia.com>; linuxppc-dev at lists.ozlabs.org
Cc: jk at ozlabs.org; apopple at au1.ibm.com; balbirs at au1.ibm.com; Andy Ritger <ARitger at nvidia.com>; John Hubbard <jhubbard at nvidia.com>; Sherry Cheung <SCheung at nvidia.com>; Aruna Manjunatha <amanjunatha at nvidia.com>; John McKenna <jmckenna at nvidia.com>; david.daney at cavium.com; robh at kernel.org; will.deacon at arm.com; Arnd Bergmann <arnd at arndb.de>
Subject: Re: [PATCH] powerpc: Fix inconsistent of_node_to_nid EXPORT_SYMBOL handling

Shailendra Singh <shailendras at nvidia.com> writes:

> The generic implementation of of_node_to_nid is EXPORT_SYMBOL.

True. Added in 298535c00a2c, in April 2016.

> The powerpc implementation added by following commit is EXPORT_SYMBOL_GPL.
> commit 953039c8df7b ("[PATCH] powerpc: Allow devices to register with 
> numa
> topology")

Which was merged in May 2006.

So the powerpc version has almost 10 years precedence.
[Shailendra] - Agreed. Keeping the licensing consistent will help drivers making use of it on all architectures.

> This creates an inconsistency for of_node_to_nid callers across 
> architectures.
>
> Update the powerpc implementation to be exported consistently with the 
> generic implementation.

But I guess it's a pretty boring API. So I'll merge this unless anyone else objects.
[Shailendra] - Thanks. Appreciate your quick response.

cheers


> Signed-off-by: Shailendra Singh <shailendras at nvidia.com>
> Reviewed-by: Andy Ritger <aritger at nvidia.com>
> ---
>  arch/powerpc/mm/numa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 
> b1099cb2f393..8aa4ca3c84c9 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)
>  
>  	return nid;
>  }
> -EXPORT_SYMBOL_GPL(of_node_to_nid);
> +EXPORT_SYMBOL(of_node_to_nid);
>  
>  static int __init find_min_common_depth(void)  {
> --
> 2.4.11
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------