[PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

Nicolin Chen nicoleotsuka at gmail.com
Tue Dec 5 07:46:33 AEDT 2017

The fsl_ssi driver was designed for PPC originally and then it has
been updated to support different modes for i.MX Series, including
SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different
contributors for different use cases in different coding styles.

Additionally, in order to fix/work-around hardware bugs and design
flaws, the driver made a lot of compromise so now its program flow
looks very complicated and it's getting hard to maintain or update.

So I am going to clean up the driver in both coding style level and
program flow level.

This series of patches is the first set to clean up fsl_ssi driver
in the coding style level. Any patch here is not supposed to change
the program flow.

Theoretically, it only needs code review, build and sanity tests. I
have done build and sanity tests on an i.MX 6 platform by building
using imx_v6_v7_defconfig and testing with I2S slave/master mode.

Nicolin Chen (10):
  ASoC: fsl_ssi: Remove unused struct device
  ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi
  ASoC: fsl_ssi: Cache pdev->dev pointer
  ASoC: fsl_ssi: Refine all comments
  ASoC: fsl_ssi: Rename registers and fields macros
  ASoC: fsl_ssi: Refine indentations and wrappings
  ASoC: fsl_ssi: Refine printk outputs
  ASoC: fsl_ssi: Rename cpu_dai parameter to dai
  ASoC: fsl_ssi: Rename scr_val to scr
  ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals

 sound/soc/fsl/fsl_ssi.c     | 1338 +++++++++++++++++++------------------------
 sound/soc/fsl/fsl_ssi.h     |  422 ++++++++------
 sound/soc/fsl/fsl_ssi_dbg.c |   59 +-
 3 files changed, 846 insertions(+), 973 deletions(-)


More information about the Linuxppc-dev mailing list