[PATCH kernel 4/5] powerpc/eeh: Remove unnecessary config_addr from eeh_dev

Michael Ellerman mpe at ellerman.id.au
Mon Aug 28 16:27:30 AEST 2017


Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> The eeh_dev struct hold a config space address of an associated node
> and the very same address is also stored in the pci_dn struct which
> is always present during the eeh_dev lifetime.
>
> This uses bus:devfn directly from pci_dn instead of cached and packed
> config_addr.
>
> Since config_addr is made from device's bus:dev.fn, there is no point
> in keeping it in the debugfs either so remove that too.
>
> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
> ---
>  arch/powerpc/include/asm/eeh.h               |  1 -
>  arch/powerpc/kernel/eeh_pe.c                 | 42 ++++++++++++++--------------
>  arch/powerpc/kernel/eeh_sysfs.c              |  3 --
>  arch/powerpc/platforms/powernv/eeh-powernv.c |  9 +++---

  arch/powerpc/platforms/pseries/eeh_pseries.c:257:7: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?
  edev->config_addr = (pdn->busno << 16) | (pdn->devfn << 8);
      ^~
  arch/powerpc/platforms/pseries/eeh_pseries.c:282:8: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?
   edev->config_addr = pdn_to_eeh_dev(pdn->parent)->config_addr;
       ^~
  arch/powerpc/platforms/pseries/eeh_pseries.c:282:51: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?
   edev->config_addr = pdn_to_eeh_dev(pdn->parent)->config_addr;
                                                   ^~
cheers


More information about the Linuxppc-dev mailing list