should "linux-phandle" be "linux,phandle"?

Michael Ellerman mpe at ellerman.id.au
Wed Aug 16 16:11:37 AEST 2017


rpjday at crashcourse.ca writes:

>    pedantic nitpickery but, in arch/powerpc/kernel/prom_init.c, line 2426,
> should that diagnostic message print "<linux,phandle>" and not  
> "<linux-phandle>"?

Yeah I guess.

AFAICS it can't happen though, we created the "linux,phandle" string
just prior, around line 2488.

So it could just be:

		soff = dt_find_string("linux,phandle");
		if (soff == 0)
			prom_printf("WARNING: Wat?!\n");
		else
			...

cheers


More information about the Linuxppc-dev mailing list