[PATCH 2/2] powerpc/powernv/npu: Don't explicitly flush nmmu tlb

[kbuild test robot]

Hi Alistair,

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.13-rc4 next-20170811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alistair-Popple/powerpc-powernv-npu-Move-tlb-flush-before-launching-ATSD/20170813-211752
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/platforms/powernv/npu-dma.c: In function 'pnv_npu2_init_context':
>> arch/powerpc/platforms/powernv/npu-dma.c:746:3: error: implicit declaration of function 'mm_context_set_global_tlbi' [-Werror=implicit-function-declaration]
      mm_context_set_global_tlbi(&mm->context);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/mm_context_set_global_tlbi +746 arch/powerpc/platforms/powernv/npu-dma.c

   652	
   653	/*
   654	 * Call into OPAL to setup the nmmu context for the current task in
   655	 * the NPU. This must be called to setup the context tables before the
   656	 * GPU issues ATRs. pdev should be a pointed to PCIe GPU device.
   657	 *
   658	 * A release callback should be registered to allow a device driver to
   659	 * be notified that it should not launch any new translation requests
   660	 * as the final TLB invalidate is about to occur.
   661	 *
   662	 * Returns an error if there no contexts are currently available or a
   663	 * npu_context which should be passed to pnv_npu2_handle_fault().
   664	 *
   665	 * mmap_sem must be held in write mode.
   666	 */
   667	struct npu_context *pnv_npu2_init_context(struct pci_dev *gpdev,
   668				unsigned long flags,
   669				struct npu_context *(*cb)(struct npu_context *, void *),
   670				void *priv)
   671	{
   672		int rc;
   673		u32 nvlink_index;
   674		struct device_node *nvlink_dn;
   675		struct mm_struct *mm = current->mm;
   676		struct pnv_phb *nphb;
   677		struct npu *npu;
   678		struct npu_context *npu_context;
   679	
   680		/*
   681		 * At present we don't support GPUs connected to multiple NPUs and I'm
   682		 * not sure the hardware does either.
   683		 */
   684		struct pci_dev *npdev = pnv_pci_get_npu_dev(gpdev, 0);
   685	
   686		if (!firmware_has_feature(FW_FEATURE_OPAL))
   687			return ERR_PTR(-ENODEV);
   688	
   689		if (!npdev)
   690			/* No nvlink associated with this GPU device */
   691			return ERR_PTR(-ENODEV);
   692	
   693		if (!mm || mm->context.id == 0) {
   694			/*
   695			 * Kernel thread contexts are not supported and context id 0 is
   696			 * reserved on the GPU.
   697			 */
   698			return ERR_PTR(-EINVAL);
   699		}
   700	
   701		nphb = pci_bus_to_host(npdev->bus)->private_data;
   702		npu = &nphb->npu;
   703	
   704		/*
   705		 * Setup the NPU context table for a particular GPU. These need to be
   706		 * per-GPU as we need the tables to filter ATSDs when there are no
   707		 * active contexts on a particular GPU.
   708		 */
   709		rc = opal_npu_init_context(nphb->opal_id, mm->context.id, flags,
   710					PCI_DEVID(gpdev->bus->number, gpdev->devfn));
   711		if (rc < 0)
   712			return ERR_PTR(-ENOSPC);
   713	
   714		/*
   715		 * We store the npu pci device so we can more easily get at the
   716		 * associated npus.
   717		 */
   718		npu_context = mm->context.npu_context;
   719		if (!npu_context) {
   720			npu_context = kzalloc(sizeof(struct npu_context), GFP_KERNEL);
   721			if (!npu_context)
   722				return ERR_PTR(-ENOMEM);
   723	
   724			mm->context.npu_context = npu_context;
   725			npu_context->mm = mm;
   726			npu_context->mn.ops = &nv_nmmu_notifier_ops;
   727			__mmu_notifier_register(&npu_context->mn, mm);
   728			kref_init(&npu_context->kref);
   729		} else {
   730			kref_get(&npu_context->kref);
   731		}
   732	
   733		npu_context->release_cb = cb;
   734		npu_context->priv = priv;
   735		nvlink_dn = of_parse_phandle(npdev->dev.of_node, "ibm,nvlink", 0);
   736		if (WARN_ON(of_property_read_u32(nvlink_dn, "ibm,npu-link-index",
   737								&nvlink_index)))
   738			return ERR_PTR(-ENODEV);
   739		npu_context->npdev[npu->index][nvlink_index] = npdev;
   740	
   741		if (!nphb->npu.nmmu_flush)
   742			/*
   743			 * If we're not explicitly flushing ourselves we need to mark
   744			 * the thread for global flushes
   745			 */
 > 746			mm_context_set_global_tlbi(&mm->context);
   747	
   748		return npu_context;
   749	}
   750	EXPORT_SYMBOL(pnv_npu2_init_context);
   751	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 23572 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20170814/de9f7b7e/attachment-0001.gz>