[v5 1/2] lib/raid6: Build proper files on corresponding arch

Matt Brown matthew.brown.dev at gmail.com
Fri Aug 4 11:33:39 AEST 2017


On Wed, Aug 2, 2017 at 12:00 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> Daniel Axtens <dja at axtens.net> writes:
>
>> Hi Matt,
>>
>>> --- a/lib/raid6/test/Makefile
>>> +++ b/lib/raid6/test/Makefile
>>> @@ -44,10 +44,12 @@ else ifeq ($(HAS_NEON),yes)
>>>          CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
>>>  else
>>>          HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
>>> -                         gcc -c -x c - >&/dev/null && \
>>> -                         rm ./-.o && echo yes)
>>> +                         gcc -c -x c - >/dev/null && rm ./-.o && echo yes)
>>
>> From memory the change here (s/>&/>/) was necessary to get the build to
>> succeed - did we ever figure out why that was? I'm not enough of a shell
>> guru to grok the difference.
>
> Using >& redirects stdout and stderr, whereas > only redirects stdout.
>
> So possibly it doesn't fix anything, but rather lets you see any error
> emitted by the compiler rather than swallowing it?
>

Just had to double-check what the problem was.
The bug was that none of the ppc specific files were being built.
I'm not entirely sure how, but this fixes it so the altivec and
vpermxor files are built.

I'll fix up the commit message and move the vpermxor make defs into
the other patch.

Thanks,
Matt

> cheers


More information about the Linuxppc-dev mailing list